samples: Bluetooth: PBP: Source: Fix advertising data #80925
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sample had a few off-by-ones in the code, which caused access to invalid data. Fixed by setting the right buffer sizes and the right AD length fields. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
nashif,
niym-ot,
pin-zephyr and
sjanc
aescolar
approved these changes
Nov 5, 2024
babrsn
approved these changes
Nov 6, 2024
kruithofa
approved these changes
Nov 6, 2024
|
@Thalley , not needed for 4.0? |
Feel free to merge it, but it has no bug report and it's just a minor bug for a sample :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample had a few off-by-ones in the code, which caused access to invalid data.
Fixed by setting the right buffer sizes and the right AD length fields.
See also #80924